Re: [PATCH] staging: fbtft: Remove unused macro
From: Andy Shevchenko
Date: Mon Oct 26 2026 - 05:26:01 EST
On Mon, Oct 26, 2026 at 11:23:17AM +0200, Andy Shevchenko wrote:
> On Mon, Oct 26, 2026 at 01:48:32PM +0530, himanshu bakshi wrote:
> >
> > fbtft_init_dbg is not used in drivers/staging/fbtft directory and
>
> We refer to the functions and semantically similar macros as
> func() or macro() in the text and comments.
>
> > since dev_dbg messages are good enough, fbtft_init_dbg should be
>
> Ditto for both dev_dbg() and fbtft_init_dbg().
>
> > removed. After compiling the driver, there are no undefined macro
> > issues.
>
> > Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@xxxxxxxxx>
> > ---
>
> It doesn't say how you tested this, though.
Ah, after reading Dan's email I noticed that the last sentence in the commit
message actually should be located here, in the comment block.
--
With Best Regards,
Andy Shevchenko