Re: [PATCH 2/2] hid: asus: always fully initialize devices

[Sakari Ailus]

Hi Denis,

Thanks for your reply.

On Mon, Oct 26, 2026 at 11:00:52AM +0100, Denis Benato wrote:
> 26 ott 2026 10:55:55 Sakari Ailus <sakari.ailus@xxxxxx>:
> 
> > Hi Benato,
> >
> > On Mon, Feb 16, 2026 at 06:55:39PM +0100, Denis Benato wrote:
> >> ASUS has more devices other than laptop keyboards which needs
> >> to be initializated: the init sequence is the same as keyboards.
> >>
> >> ID1 and ID2 are USB report IDs that are correctly enumerated:
> >> send init commands to all devices that supports those reports IDs.
> >>
> >> Signed-off-by: Denis Benato <denis.benato@xxxxxxxxx>
> >
> > This patch appears to break input devices on Asus T100TA. With the patch
> > applied, I'm getting a steady flow of:
> >
> > [  256.358075] usb 1-3: USB disconnect, device number 120
> > [  257.034324] usb 1-3: new full-speed USB device number 121 using xhci_hcd
> > [  257.175003] usb 1-3: New USB device found, idVendor=0b05, idProduct=17e0, bcdDevice= 2.49
> > [  257.175050] usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> > [  257.175073] usb 1-3: Product: ASUS Base Station(T100)
> > [  257.175091] usb 1-3: Manufacturer: ASUSTek COMPUTER INC.
> > [  257.180978] input: ASUSTek COMPUTER INC. ASUS Base Station(T100) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:0B05:17E0.02DB/input/input749
> > [  257.266585] asus 0003:0B05:17E0.02DB: input,hidraw1: USB HID v1.11 Keyboard [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input0
> > [  257.270711] asus 0003:0B05:17E0.02DC: Fixing up Asus T100 keyb report descriptor
> > [  257.272302] input: ASUSTek COMPUTER INC. ASUS Base Station(T100) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.1/0003:0B05:17E0.02DC/input/input750
> > [  257.327059] asus 0003:0B05:17E0.02DC: input,hiddev0,hidraw2: USB HID v1.11 Device [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input1
> > [  257.332642] input: ASUSTek COMPUTER INC. ASUS Base Station(T100) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.2/0003:0B05:17E0.02DD/input/input751
> > [  257.334115] asus 0003:0B05:17E0.02DD: input,hiddev1,hidraw3: USB HID v1.11 Mouse [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input2
> > [  257.336098] asus 0003:0B05:17E0.02DD: Asus handshake 5d failed to send: -71
> > [  257.336263] asus 0003:0B05:17E0.02DD: Failed to initialize 0x5d: -71.
> > [  257.336605] asus 0003:0B05:17E0.02DD: Asus failed to start multitouch: -71
> > [  257.367022] asus 0003:0B05:17E0.02DD: probe with driver asus failed with error -71
> > [  257.367917] usb 1-3: USB disconnect, device number 121
> >
> > I haven't tried to debug this yet so just FYI.
> >
> 
> Hi Sakari,
> 
> Thanks for testing this! Is that device of yours a touchpad? This commit has been bugfixed before and the issue is related to report sizes being sent as 64 bytes (and also additional unsupported messages in the case of touchpads).
> 
> Can you try linux-next please? That has all bugfixes for already known problems.

I can confirm the issue has been fixed in next.

-- 
Kind regards,

Sakari Ailus