Re: [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger
From: Björn Töpel
Date: Tue Oct 27 2026 - 05:56:01 EST
Avi Weiss <thnkslprpt@xxxxxxxxx> writes:
> imsic_irq_retrigger() writes to the IMSIC MSI register to retrigger
> an interrupt, but returns 0. The IRQ core treats zero as failure and
> may schedule a software resend despite the hardware retrigger.
>
> Return 1 after the MSI write to report successful hardware
> retriggering and prevent the unnecessary software resend.
>
> Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
> Signed-off-by: Avi Weiss <thnkslprpt@xxxxxxxxx>
Nice catch!
Reviewed-by: Björn Töpel <bjorn@xxxxxxxxxx>