Re: [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger

[Anup Patel]

On Mon, Oct 26, 2026 at 5:56 PM Avi Weiss <thnkslprpt@xxxxxxxxx> wrote:
>
> imsic_irq_retrigger() writes to the IMSIC MSI register to retrigger
> an interrupt, but returns 0. The IRQ core treats zero as failure and
> may schedule a software resend despite the hardware retrigger.
>
> Return 1 after the MSI write to report successful hardware
> retriggering and prevent the unnecessary software resend.
>
> Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
> Signed-off-by: Avi Weiss <thnkslprpt@xxxxxxxxx>

Thanks for catching.

Reviewed-by: Anup Patel <anup@xxxxxxxxxxxxxx>

Regards,
Anup

> ---
>  drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
> index 95ff76e63a69..5f72b2a80887 100644
> --- a/drivers/irqchip/irq-riscv-imsic-platform.c
> +++ b/drivers/irqchip/irq-riscv-imsic-platform.c
> @@ -61,7 +61,7 @@ static int imsic_irq_retrigger(struct irq_data *d)
>
>         local = per_cpu_ptr(imsic->global.local, vec->cpu);
>         writel_relaxed(vec->local_id, local->msi_va);
> -       return 0;
> +       return 1;
>  }
>
>  static void imsic_irq_ack(struct irq_data *d)
>
> base-commit: 6b4b543fa18757297ac756a6fe6e64f506b7844a
> --
> 2.43.0
>