Re: [PATCH v8 1/2] dt-bindings: usb: Add CIX Sky1 USBSSP controller
From: Krzysztof Kozlowski
Date: Mon Nov 16 2026 - 05:13:28 EST
On Thu, Nov 12, 2026 at 10:21:40AM +0800, Hongliang Yang wrote:
> +required:
> + - compatible
> + - reg
> + - ranges
> + - "#address-cells"
> + - "#size-cells"
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> + - cix,usb-syscon
> +
> +patternProperties:
> + "^usb@[0-9a-f]+$":
> + $ref: cdns,usb3.yaml#
Please move patternProperties before "required:" block.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/cix,sky1.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/reset/cix,sky1-s5-system-control.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + usb@91c0314 {
> + compatible = "cix,sky1-usbssp";
> + reg = <0x00 0x91c0314 0x00 0x100>;
> + ranges;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + clocks = <&scmi_clk CLK_TREE_USB3A_H0_CLK_SOF>,
> + <&scmi_clk CLK_TREE_USB3A_0_AXI_GATE>,
> + <&scmi_clk CLK_TREE_USB3A_H0_CLK_LPM>,
> + <&scmi_clk CLK_TREE_USB3A_0_APB_GATE>;
> + clock-names = "sof", "axi", "lpm", "apb";
> + resets = <&src SKY1_USBC_SS2_PRST_N>,
> + <&src SKY1_USBC_SS2_RST_N>;
> + reset-names = "apb", "core";
> + cix,usb-syscon = <&src 0x424 8>;
> +
> + usb@91d0000 {
> + compatible = "cdns,usb3";
> + reg = <0x00 0x91d0000 0x00 0x4000>,
> + <0x00 0x91d8000 0x00 0x8000>,
> + <0x00 0x91d4000 0x00 0x4000>;
> + reg-names = "otg", "xhci", "dev";
> + dr_mode = "otg";
> +
> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "host", "peripheral", "otg", "wakeup";
> + maximum-speed = "super-speed-plus";
> +
> + phys = <&usb3_phy4>, <&usb2_phy4>;
> + phy-names = "cdns3,usb3-phy", "cdns3,usb2-phy";
> + };
> + };
> +
> + usb2_phy4: usb-phy {
> + compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> + };
And drop usb-phy
With these two:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
Best regards,
Krzysztof