Re: [PATCH 14/35] iio: accel: bma400: use default_trigger

From: Linus Walleij

Date: Mon Nov 16 2026 - 05:13:37 EST


On Mon, Nov 16, 2026 at 2:50 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> From: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>
>
> Set indio_dev->default_trigger rather than taking a reference to the
> trigger in probe(). The IIO core now takes the reference during
> iio_device_register(), so it is not leaked if probe() fails after
> the trigger is set up. Whilst this closes a potential leak, it
> also makes the ordering going forwards a lot less fragile.
>
> Fixes: ffe0ab6a9698 ("iio: accel: bma400: Add triggered buffer support")
> Signed-off-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij