Re: [PATCH] RDMA/ocrdma: Fix potential EQ table leak
From: Leon Romanovsky
Date: Mon Nov 16 2026 - 06:56:14 EST
On Thu, Nov 12, 2026 at 09:59:12PM +0800, Guangshuo Li wrote:
> EQ teardown destroys the individual queues but leaves their dynamically
> allocated table behind. Free the table after all EQs have been destroyed
> and reset its pointer and count.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter")
> Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> index 006ef2e6b5f3..4a977281a85b 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> @@ -518,6 +518,9 @@ static void ocrdma_destroy_eqs(struct ocrdma_dev *dev)
>
> for (i = 0; i < dev->eq_cnt; i++)
> ocrdma_destroy_eq(dev, &dev->eq_tbl[i]);
> + kfree(dev->eq_tbl);
> + dev->eq_tbl = NULL;
> + dev->eq_cnt = 0;
These two lines are unnecessary because dev->eq_tbl is not reused.
Thanks
> }
>
> static int ocrdma_mbx_mq_cq_create(struct ocrdma_dev *dev,
>
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4