Re: [PATCH 5/7] KVM: Fix comments that refer to non-existent identifiers
From: Zenghui Yu
Date: Mon Nov 16 2026 - 06:56:43 EST
On 2026/11/11 16:54, Fuad Tabba wrote:
> Comments in the generic KVM code and its headers refer to functions,
> structures, fields, capabilities and Kconfig symbols that have been
> misspelled or renamed. Use the current names.
>
> Signed-off-by: Fuad Tabba <fuad.tabba@xxxxxxxxx>
> ---
> include/linux/kvm_dirty_ring.h | 2 +-
> include/linux/kvm_host.h | 4 ++--
> include/linux/kvm_irqfd.h | 4 ++--
> include/uapi/linux/kvm.h | 2 +-
> virt/kvm/binary_stats.c | 2 +-
> virt/kvm/eventfd.c | 2 +-
> virt/kvm/kvm_main.c | 2 +-
> 7 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/kvm_dirty_ring.h b/include/linux/kvm_dirty_ring.h
> index eb10d87adf7d5..8679ba17bd1ff 100644
> --- a/include/linux/kvm_dirty_ring.h
> +++ b/include/linux/kvm_dirty_ring.h
> @@ -29,7 +29,7 @@ struct kvm_dirty_ring {
>
> #ifndef CONFIG_HAVE_KVM_DIRTY_RING
> /*
> - * If CONFIG_HAVE_HVM_DIRTY_RING not defined, kvm_dirty_ring.o should
> + * If CONFIG_HAVE_KVM_DIRTY_RING not defined, kvm_dirty_ring.o should
> * not be included as well, so define these nop functions for the arch.
> */
The comment looks a bit obscure. We can rewrite it as
" If CONFIG_HAVE_KVM_DIRTY_RING is not defined, dirty_ring.o will not be
built either, so define these nop functions for the arch. "
And personally I tend to remove it :-)
Thanks,
Zenghui