[RFC PATCH 1/4] drm/bridge: Add atomic_sro_install_state hook

From: Màxim Pedraza Padilla

Date: Mon Nov 16 2026 - 08:27:19 EST


The state readout core lets private objects take the resources needed to
keep the hardware running when the state read out becomes current, but
bridges have no way to use it. A panel left on by the firmware, for one,
would stay marked as disabled.

Add a bridge hook and call it from the bridge private object.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Màxim Pedraza Padilla <maximpedraza@xxxxxxxxx>
---
drivers/gpu/drm/drm_bridge.c | 12 ++++++++++++
include/drm/drm_bridge.h | 12 ++++++++++++
2 files changed, 24 insertions(+)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index 45a34bbb8f14..cdfd6d44c8d5 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -629,6 +629,17 @@ drm_bridge_atomic_readout_priv_state(struct drm_private_obj *obj,
return 0;
}

+static void
+drm_bridge_atomic_install_priv_state(struct drm_private_obj *obj,
+ struct drm_private_state *state)
+{
+ struct drm_bridge *bridge = drm_priv_to_bridge(obj);
+
+ if (bridge->funcs->atomic_sro_install_state)
+ bridge->funcs->atomic_sro_install_state(bridge,
+ drm_priv_to_bridge_state(state));
+}
+
static bool drm_bridge_atomic_compare_priv_state(struct drm_private_obj *obj,
struct drm_printer *p,
struct drm_private_state *a,
@@ -674,6 +685,7 @@ static const struct drm_private_state_funcs drm_bridge_priv_state_funcs = {
static const struct drm_private_state_funcs drm_bridge_priv_state_funcs_with_sro = {
.atomic_sro_compare_state = drm_bridge_atomic_compare_priv_state,
.atomic_sro_readout_state = drm_bridge_atomic_readout_priv_state,
+ .atomic_sro_install_state = drm_bridge_atomic_install_priv_state,
.atomic_create_state = drm_bridge_atomic_create_priv_state,
.atomic_duplicate_state = drm_bridge_atomic_duplicate_priv_state,
.atomic_destroy_state = drm_bridge_atomic_destroy_priv_state,
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index b73f3424ed62..630af5b3fcf2 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -967,6 +967,18 @@ struct drm_bridge_funcs {
struct drm_atomic_sro_state *state,
struct drm_connector_state *conn_state);

+ /**
+ * @atomic_sro_install_state:
+ *
+ * This optional hook is called when the state read out from the
+ * hardware becomes the current state of the bridge, once the CRTCs
+ * and planes have been installed. It gives the bridge a chance to
+ * take the resources needed to keep the hardware running. It can't
+ * fail.
+ */
+ void (*atomic_sro_install_state)(struct drm_bridge *bridge,
+ struct drm_bridge_state *state);
+
/**
* @debugfs_init:
*
--
2.39.5