[PATCH] media: ngene: Fix potential stale I2C adapter on initialization failure

From: Guangshuo Li

Date: Mon Nov 16 2026 - 09:15:53 EST


If the second I2C adapter fails to register, ngene_start() leaves the
first adapter registered. Probe subsequently frees the device that
contains that adapter.

Unregister the first adapter before shutting down interrupts on this
error path.

This issue was found by our static analysis tool under development.

Fixes: dae52d009fc9 ("V4L/DVB: ngene: Initial check-in")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
---
drivers/media/pci/ngene/ngene-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/pci/ngene/ngene-core.c b/drivers/media/pci/ngene/ngene-core.c
index db6796240bce..b2864abe4b81 100644
--- a/drivers/media/pci/ngene/ngene-core.c
+++ b/drivers/media/pci/ngene/ngene-core.c
@@ -1368,10 +1368,12 @@ static int ngene_start(struct ngene *dev)

stat = ngene_i2c_init(dev, 1);
if (stat < 0)
- goto fail;
+ goto fail_i2c;

return 0;

+fail_i2c:
+ i2c_del_adapter(&dev->channel[0].i2c_adapter);
fail:
ngwritel(0, NGENE_INT_ENABLE);
free_irq(dev->pci_dev->irq, dev);

base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4