[PATCH 6/8] soc: synaptics: Populate SL2610 system controller DT children
From: Jisheng Zhang
Date: Mon Nov 16 2026 - 09:16:01 EST
The SL2610 system controller currently creates only its fixed clock,
reset and pinctrl MFD devices. DT children such as the MDIO mmio-mux
therefore never become platform devices, leaving their consumers in
deferred probe indefinitely.
Populate enabled DT children after adding the MFD devices. Use the
managed helper to remove these children before the MFD devices during
teardown and probe-error cleanup.
Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
Assisted-by: LLM
---
drivers/soc/synaptics/sl2610-syscon.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/synaptics/sl2610-syscon.c b/drivers/soc/synaptics/sl2610-syscon.c
index c6fc2955ac0d..b7965f4bb963 100644
--- a/drivers/soc/synaptics/sl2610-syscon.c
+++ b/drivers/soc/synaptics/sl2610-syscon.c
@@ -6,6 +6,7 @@
#include <linux/mfd/core.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
struct sl2610_syscon_data {
@@ -56,9 +57,14 @@ static const struct sl2610_syscon_data sl2610_cpu_data = {
static int sl2610_syscon_probe(struct platform_device *pdev)
{
const struct sl2610_syscon_data *data = device_get_match_data(&pdev->dev);
+ int ret;
- return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,
- data->cells, data->num_cells, NULL, 0, NULL);
+ ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,
+ data->cells, data->num_cells, NULL, 0, NULL);
+ if (ret)
+ return ret;
+
+ return devm_of_platform_populate(&pdev->dev);
}
static const struct of_device_id sl2610_syscon_of_match[] = {
--
2.55.0