Re: [PATCH v2 5/7] dt-bindings: pinctrl: airoha: add AN7589
From: John Crispin
Date: Mon Nov 16 2026 - 12:47:46 EST
On Fri, Nov 13, 2026 at 05:40:42PM +0000, Conor Dooley wrote:
> As Lee requested, please split this out. Two patches, maybe even three.
Agreed. v3 splits it into three patches.
> Do we even need a child node here? If all this node does is
> gpio/pinctrl, why can the driver not bind directly to this node?
>
> What else does it do that warrants being a syscon?
The block also holds the PWM controller. Its registers interleave with
the GPIO ones. The PWM series adds it as a second child, as on the
EN7581. That series has a depency on this one so I have not posted it yet.
> Otherwise, there should only be one. uart1 and uart2 should have
> different nodes.
Agreed. v3 sets maxItems to 1. Only pcm_spi and pcie keep more, as
their groups carry different signals of one device.
> So here, maxItems should be 1 for similar reasons.
Agreed, v3 does this for i2c too.
> I'm also curious about why this goes up to 74. None of the functions
> have 74 pins, surely?
A conf node can set the same config on any set of pins. 74 is all the
pins. The EN7581 binding does the same with 58.
v3 will follow shortly.
John