Re: [PATCH net-next] net: dsa: mv88e6xxx: Enable LED control on 88E6171
From: Aleksander Jan Bajkowski
Date: Mon Nov 16 2026 - 15:50:09 EST
Hi Andrew,
On 15/11/2026 19:54, Andrew Lunn wrote:
On Sun, Nov 15, 2026 at 07:12:36PM +0100, Aleksander Jan Bajkowski wrote:
Enable LED control on the Marvell 88E6171. This switch uses a registerPlease break this patch up.
layout similar to the 6352 family, but has 4 LEDs instead of 2. Hardware
triggers are not supported at this moment.
.num_leds makes a lot of sense, but please introduce it as a patch.
.led_hw_triggers i'm not sure about. But please add it as a patch of
its own.
@@ -4609,6 +4609,7 @@ static const struct mv88e6xxx_ops mv88e6171_ops = {static const struct mv88e6xxx_ops mv88e6171_ops = {
.port_pause_limit = mv88e6097_port_pause_limit,
.port_disable_learn_limit = mv88e6xxx_port_disable_learn_limit,
.port_disable_pri_override = mv88e6xxx_port_disable_pri_override,
+ .port_setup_leds = mv88e6xxx_port_setup_leds,
.port_get_cmode = mv88e6352_port_get_cmode,
.port_setup_message_port = mv88e6xxx_setup_message_port,
.stats_snapshot = mv88e6xxx_g1_stats_snapshot,
/* MV88E6XXX_FAMILY_6351
I assume these changes work for all members of the family?
Most likely. The ON/OFF and BLINK controls should work the
same across variious Marvell switch families. I think only
the hardware triggers differ between switch families. I can
also confirm that the 88E6341 shares the same register layout.
However, this switch has 3 LEDs. I don't have access to other
Marvell switches.
Best regards,
Aleksander