[PATCH] drm/bridge: adv7511: Accept S32_LE I2S samples
From: Joseph Telaak
Date: Mon Nov 16 2026 - 16:59:21 EST
Commit 7c3127e4814c ("drm: bridge: adv7511: remove s32 format from i2s
capabilities") dropped S32_LE, which adv7511_hdmi_audio_prepare()
rejected, as the ADV7511 takes at most 24 bits per I2S sample.
A CPU DAI whose only format wider than 16 bits is S32_LE, and that puts
no padding between words, then has no format for 32-bit slots. As
hdmi-codec's I2S_FORMATS comment says, a 32-bit format gives such DAIs
24-bit precision. Advertise S32_LE again and program it like S24_LE: in
I2S and left-justified modes the ADV7511 takes the top 24 bits of the
slot, and hdmi-codec reports 24 significant bits. Right-justified it
would take the low 24 bits, so a 32-bit sample is still refused there.
Tested only on an ADV7513 fed 2 x 32-bit I2S slots by an OMAP3630
McBSP, where a left-only and a right-only S32_LE tone at 44.1 kHz both
play at full level.
Signed-off-by: Joseph Telaak <joseph@xxxxxxxxxx>
---
Found while adding set_tdm_slot to omap-mcbsp, posted separately to
linux-sound. omap-mcbsp offers only S16_LE and S32_LE.
---
drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 4 +++-
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
index 87e7e820810a..8e38b936ef6c 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
@@ -105,7 +105,9 @@ int adv7511_hdmi_audio_prepare(struct drm_bridge *bridge,
len = ADV7511_I2S_SAMPLE_LEN_20;
break;
case 32:
- if (fmt->bit_fmt != SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE)
+ /* Right-justified takes the low 24 bits of a 32-bit slot */
+ if (fmt->fmt == HDMI_RIGHT_J &&
+ fmt->bit_fmt != SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE)
return -EINVAL;
fallthrough;
case 24:
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index d3964adbb106..0cff81a6c086 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1351,6 +1351,7 @@ static int adv7511_probe(struct i2c_client *i2c)
SNDRV_PCM_FMTBIT_S20_3LE |
SNDRV_PCM_FMTBIT_S24_3LE |
SNDRV_PCM_FMTBIT_S24_LE |
+ SNDRV_PCM_FMTBIT_S32_LE |
SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE),
adv7511->bridge.hdmi_audio_spdif_playback = 1;
adv7511->bridge.hdmi_audio_dai_port = 2;
---
base-commit: 17a180572ca50c8d38f3aa47d6fc81ce7c5594da
change-id: 20261115-adv7511-s32-58d2cc14bab0
Best regards,
--
Joseph Telaak <joseph@xxxxxxxxxx>