Re: [PATCH net 2/2] tcp: accecn: initialize AccECN fields in syncookie path

From: Thaison Phan

Date: Mon Nov 16 2026 - 16:59:25 EST


On Mon, Nov 16, 2026 at 02:16:40PM +0000, Chia-Yu Chang (Nokia) wrote:
> Thanks for the fix, the only change I propose is to clarify the above message into:
>
> "For AccECN connections where the listener marks ECT on the SYN-ACK, leaving
> syn_ect_snt as 0 causes tcp_accecn_third_ack() to see a mismatch between the
> expected Not-ECT and the peer's reflected ECT in the ACE field, erroneously
> flagging TCP_ACCECN_ACE_FAIL_RECV in accecn_fail_mode.
> Refer to Table 4 of RFC 9768 for more details."
>
> Because RFC3168 ECN does not use this syn_ect_snt.

Thanks for reviewing. That wording is clearer and more precise.

I sent out v2 [1] yesterday before seeing your note, so once the 24-hour
repost window passes I will send a v3 incorporating your clarification
(assuming v2 hasn't already been picked up by then).

[1] https://lore.kernel.org/netdev/20261116023709.132684-1-thaisonphan@xxxxxxxxxx/