RE: [PATCH net 2/2] tcp: accecn: initialize AccECN fields in syncookie path
From: Chia-Yu Chang (Nokia)
Date: Mon Nov 16 2026 - 09:16:55 EST
> -----Original Message-----
> From: Thaison Phan <thaisonphan@xxxxxxxxxx>
> Sent: Saturday, November 14, 2026 5:13 PM
> To: Eric Dumazet <edumazet@xxxxxxxxxx>; Neal Cardwell <ncardwell@xxxxxxxxxx>; Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Ilpo Järvinen <ij@xxxxxxxxxx>; Olivier Tilmans (Nokia) <olivier.tilmans@xxxxxxxxx>; Chia-Yu Chang (Nokia) <chia-yu.chang@xxxxxxxxxxxxxxxxxxx>
> Cc: Simon Horman <horms@xxxxxxxxxx>; Stan Iliev <stani@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Thaison Phan <thaisonphan@xxxxxxxxxx>
> Subject: [PATCH net 2/2] tcp: accecn: initialize AccECN fields in syncookie path
>
> [You don't often get email from thaisonphan@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
>
>
> If the listener marks ECT (e.g. DCTCP), leaving syn_ect_snt at 0 causes tcp_accecn_third_ack() to flag TCP_ACCECN_ACE_FAIL_RECV when the peer reflects ECT, disabling ECT for the rest of the connection.
Hi,
Thanks for the fix, the only change I propose is to clarify the above message into:
"For AccECN connections where the listener marks ECT on the SYN-ACK, leaving syn_ect_snt as 0 causes tcp_accecn_third_ack() to see a mismatch between the expected Not-ECT and the peer's reflected ECT in the ACE field, erroneously flagging TCP_ACCECN_ACE_FAIL_RECV in accecn_fail_mode.
Refer to Table 4 of RFC 9768 for more details."
Because RFC3168 ECN does not use this syn_ect_snt.
Thanks.
Chia-Yu