Re: [PATCH net-next v11 08/13] net: dsa: realtek: rtl8365mb: refactor PVID handling

From: Mieczyslaw Nalewaj

Date: Tue Nov 17 2026 - 03:53:29 EST


Hi Linus,

On Tue, Nov 17, 2026 at 09:34 Linus Walleij wrote:

> What about int rtl8366_set_pvid() which is shared in realtek.h and implemented in rtl8366-core.c.
> (...)
> If you can confirm that this is the case also for PVID I can send a patch to push this into the RTL8366RB driver.

Confirmed for PVID. rtl8365mb does not use rtl8366_set_pvid(), and none of the realtek_ops VLAN callbacks you listed (get/set_vlan_mc, get/set_vlan_4k, get/set_mc_index, enable_vlan, enable_vlan4k) are used by it. Its PVID, VLAN MC and VLAN 4k handling is private to rtl8365mb_vlan.c and works on its own struct rtl8365mb_vlanmc and struct rtl8365mb_vlan4k, not on struct rtl8366_vlan_mc / rtl8366_vlan_4k.

The family_info callbacks in this series (vlan_4k_read/write, vlan_port_get_pvid, vlan_pvid_port_set/clear, ...) are only an internal split between family C and family D inside rtl8365mb. They do not touch realtek_ops, realtek.h or rtl8366-core.c, so moving the shared rtl8366 VLAN/PVID helpers into the RTL8366RB driver would not conflict with this series.

So please go ahead with that patch if you want to; I will rebase on top of it if it lands first.

Best regards,
Mieczyslaw Nalewaj