Re: [f2fs-dev] [PATCH v2 01/20] f2fs: use block-based index and size calculations in more paths
From: Chao Yu
Date: Tue Nov 17 2026 - 03:53:40 EST
On 11/16/26 12:08, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@xxxxxxxxxx>
>
> Several paths still convert between file offsets and block indices with
> PAGE_SHIFT or PAGE_SIZE, assuming that a page holds exactly one
> filesystem block. Use the F2FS_BLK_* helpers there so that they stay
> correct when the block size is smaller than PAGE_SIZE.
>
> No functional change when the block size equals PAGE_SIZE, except on
> 32-bit architectures: __complete_revoke_list() now computes the
> truncation offset and __clone_blkaddrs() the new i_size in 64 bits, so
> that they no longer overflow beyond 4GB.
>
> Signed-off-by: Daeho Jeong <daehojeong@xxxxxxxxxx>
Reviewed-by: Chao Yu <chao@xxxxxxxxxx>
Thanks,