Re: [PATCH 1/3] dt-bindings: media: qcom,mahua-iris: Add Mahua video codec
From: Vishnu Reddy
Date: Tue Nov 17 2026 - 05:42:56 EST
On 11/14/2026 8:39 AM, Deepa Guthyappa Madivalara wrote:
> Add a devicetree binding for the Iris3.9 video encoder and decoder block
> found on the Qualcomm Mahua SoC. This is a single core derivative,
> leveraging most of Glymur data with the clks, resets present only
> for vcodec0 core.
>
> Signed-off-by: Deepa Guthyappa Madivalara <deepa.madivalara@xxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/media/qcom,mahua-iris.yaml | 243 +++++++++++++++++++++
> 1 file changed, 243 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml b/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..cbae6bddf7fd4b67330ce47033874f3d349e5a3d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml
> @@ -0,0 +1,243 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,mahua-iris.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Mahua SoC Iris video encoder and decoder
> +
> +maintainers:
> + - Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> +
> +description:
> + The Iris video processing unit on Qualcomm Mahua SoC is a video encode and
> + decode accelerator.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - const: qcom,mahua-iris
> + - const: qcom,glymur-iris
> + - const: qcom,mahua-iris
> +
> + clocks:
> + maxItems: 6
> +
> + clock-names:
> + items:
> + - const: core_iface
> + - const: core
> + - const: vcodec0_core
> + - const: vcodec0_iface
> + - const: core_freerun
> + - const: vcodec0_core_freerun
> +
> + dma-coherent: true
> +
> + interconnects:
> + maxItems: 2
> +
> + interconnect-names:
> + items:
> + - const: cpu-cfg
> + - const: video-mem
> +
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
> +
> + non-pixel:
> + type: object
> + description:
> + Context bank for VPU non-pixel buffers, including compressed and internal buffers.
> + properties:
> + iommus:
> + maxItems: 3
> + memory-region:
> + maxItems: 1
The use of memory-region for specifying carveout regions was discussed
previously and was not considered the preferred approach [1].
There is also an active series introducing iommu-ranges support for this use
case [2]. Please consider using iommu-ranges instead of relying on memory-region
here.
[1] https://lore.kernel.org/all/662f7093-fb0a-4564-9ca0-98e03e68ba9a@xxxxxxxxxx
[2]
https://lore.kernel.org/all/20261103-vpu_iommu_iova_handling-v6-0-e4b6ad864f8f@xxxxxxxxxxxxxxxx
> + required:
> + - iommus
> + - memory-region
> + additionalProperties: false
> +
> + pixel:
> + type: object
> + description:
> + Context bank for VPU pixel buffers containing uncompressed video data.
> + properties:
> + iommus:
> + maxItems: 1
> + required:
> + - iommus
> + additionalProperties: false
> +
> + video-firmware:
> + type: object
> + description:
> + Context bank for the VPU firmware processing domain.
> + properties:
> + iommus:
> + maxItems: 1
> + required:
> + - iommus
> + additionalProperties: false
> +
> + operating-points-v2: true
> + opp-table:
> + type: object
> +
> + power-domains:
> + maxItems: 5
> +
> + power-domain-names:
> + items:
> + - const: venus
> + - const: vcodec0
> + - const: mxc
> + - const: mmcx
> +
> + resets:
> + maxItems: 4
> +
> + reset-names:
> + items:
> + - const: core_bus
> + - const: vcodec0_bus
> + - const: core
> + - const: vcodec0_core
> +
> +required:
> + - clocks
> + - clock-names
> + - compatible
> + - dma-coherent
> + - interconnects
> + - interconnect-names
> + - non-pixel
> + - pixel
> + - power-domains
> + - power-domain-names
> + - resets
> + - reset-names
> +
> +allOf:
> + - $ref: qcom,venus-common.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/qcom,rpmhpd.h>
> +
> + video-codec@aa00000 {
> + compatible = "qcom,mahua-iris";
> + reg = <0x0aa00000 0xf0000>;
> +
> + clocks = <&gcc_video_axi0c_clk>,
> + <&videocc_mvs0c_clk>,
> + <&videocc_mvs0_clk>,
> + <&gcc_video_axi0_clk>,
> + <&videocc_mvs0c_freerun_clk>,
> + <&videocc_mvs0_freerun_clk>,
> +
> + clock-names = "core_iface",
> + "core",
> + "vcodec0_core",
> + "vcodec0_iface",
> + "core_freerun",
> + "vcodec0_core_freerun",
> +
> + dma-coherent;
> +
> + interconnects = <&hsc_noc_master_appss_proc &config_noc_slave_venus_cfg>,
> + <&mmss_noc_master_video &mc_virt_slave_ebi1>;
> + interconnect-names = "cpu-cfg",
> + "video-mem";
> +
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> +
> + memory-region = <&video_mem>;
> +
> + operating-points-v2 = <&iris_opp_table>;
> +
> + power-domains = <&videocc_mvs0c_gdsc>,
> + <&videocc_mvs0_gdsc>,
> + <&rpmhpd RPMHPD_MXC>,
> + <&rpmhpd RPMHPD_MMCX>,
> +
> + power-domain-names = "venus",
> + "vcodec0",
> + "mxc",
> + "mmcx";
> +
> + resets = <&gcc_video_axi0c_clk_ares>,
> + <&gcc_video_axi0_clk_ares>,
> + <&videocc_mvs0c_freerun_clk_ares>,
> + <&videocc_mvs0_freerun_clk_ares>;
> + reset-names = "core_bus",
> + "vcodec0_bus",
> + "core",
> + "vcodec0_core";
> +
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + non-pixel {
> + iommus = <&apps_smmu 0x1940 0x0000>,
> + <&apps_smmu 0x1944 0x0000>,
> + <&apps_smmu 0x19e0 0x0000>;
> + memory-region = <&iris_resv>;
> + };
> +
> + pixel {
> + iommus = <&apps_smmu 0x1943 0x0000>;
> + };
> +
> + firmware {
> + iommus = <&apps_smmu 0x19e2 0x0000>;
> + };
> +
> + iris_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-240000000 {
> + opp-hz = /bits/ 64 <240000000 360000000>;
> + required-opps = <&rpmhpd_opp_svs>,
> + <&rpmhpd_opp_low_svs>;
> + };
> +
> + opp-338000000 {
> + opp-hz = /bits/ 64 <338000000 507000000>;
> + required-opps = <&rpmhpd_opp_svs>,
> + <&rpmhpd_opp_svs>;
> + };
> +
> + opp-366000000 {
> + opp-hz = /bits/ 64 <366000000 549000000>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_svs_l1>;
> + };
> +
> + opp-444000000 {
> + opp-hz = /bits/ 64 <444000000 666000000>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_nom>;
> + };
> +
> + opp-533333334 {
> + opp-hz = /bits/ 64 <533333334 800000000>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_turbo>;
> + };
> +
> + opp-655000000 {
> + opp-hz = /bits/ 64 <655000000 982000000>;
> + required-opps = <&rpmhpd_opp_nom>,
> + <&rpmhpd_opp_turbo_l1>;
> + };
> + };
> + };
>