Re: [PATCH 1/3] dt-bindings: media: qcom,mahua-iris: Add Mahua video codec
From: Krzysztof Kozlowski
Date: Tue Nov 17 2026 - 05:45:23 EST
On 14/11/2026 04:09, Deepa Guthyappa Madivalara wrote:
> Add a devicetree binding for the Iris3.9 video encoder and decoder block
> found on the Qualcomm Mahua SoC. This is a single core derivative,
> leveraging most of Glymur data with the clks, resets present only
> for vcodec0 core.
>
> Signed-off-by: Deepa Guthyappa Madivalara <deepa.madivalara@xxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/media/qcom,mahua-iris.yaml | 243 +++++++++++++++++++++
> 1 file changed, 243 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml b/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..cbae6bddf7fd4b67330ce47033874f3d349e5a3d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml
> @@ -0,0 +1,243 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,mahua-iris.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Mahua SoC Iris video encoder and decoder
> +
> +maintainers:
> + - Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> +
> +description:
> + The Iris video processing unit on Qualcomm Mahua SoC is a video encode and
> + decode accelerator.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - const: qcom,mahua-iris
> + - const: qcom,glymur-iris
> + - const: qcom,mahua-iris
> +
I don't understand what you want to express at all. See DTS101 slides, I
gave the talk in Qualcomm office this year even.
Anyway, glymur is undocumented. There is nothing about dependencies in
top of the cover letter (sorry, not going to scroll further - you ALWAYS
put the most important information first), but anyway then it means this
is untestable or unreviewable.
Best regards,
Krzysztof