Re: [PATCH net 7/7] mptcp: fix dummy mapping of overlapping segments

From: netdev-bot+sashiko

Date: Tue Nov 17 2026 - 17:30:02 EST


Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit's author and the author's sign-off use different email
addresses.

--

mptcp: fix dummy mapping of overlapping segments

After a fallback to TCP, subflow_check_data_avail() builds a dummy
mapping. This commit computes map_subflow_seq from the first byte of the
skb at the head of the receive queue instead of from copied_seq, so that
map_subflow_seq and map_seq describe the same byte. Without this, new
bytes in a segment that partly overlaps data already received get a DSN
that is too low, and they are skipped as old data.

Link: https://lore.kernel.org/4c48d016490d43b6892c622cbae858b48f176cff.1794304840.git.tanggeliang@xxxxxxxxxx [1]

> Author: Geliang Tang <geliang@xxxxxxxxxx>

[ ... ]

> Signed-off-by: Geliang Tang <tanggeliang@xxxxxxxxxx>

[Severity: Low]
This isn't a bug, but the author address and the address in the author's
sign-off are different. The author is geliang@xxxxxxxxxx, and the only
sign-off from Geliang uses tanggeliang@xxxxxxxxxx. No sign-off uses the
author address.

scripts/checkpatch.pl reports this as a FROM_SIGN_OFF_MISMATCH warning
("From:/Signed-off-by: email address mismatch"). The names match exactly
but the addresses do not, and checkpatch does not look at .mailmap.

.mailmap already maps the two addresses to the same person:

Geliang Tang <geliang@xxxxxxxxxx> <tanggeliang@xxxxxxxxxx>

So this only affects the consistency of the tags. The DCO itself is not
in question.

Since this carries Cc: stable, could the author be set to the kylinos.cn
address, or the sign-off use geliang@xxxxxxxxxx (changed or added), before
the patch is applied?

--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261116-net-mptcp-misc-fixes-7-4-rc4-v1-0-bf7656de653e%40kernel.org