Re: [PATCH net 7/7] mptcp: fix dummy mapping of overlapping segments

From: Matthieu Baerts

Date: Wed Nov 18 2026 - 17:04:37 EST


Hello,

On 17/11/2026 23:29, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
>
> Low priority / nit picks for your consideration:

(...)

> Link: https://lore.kernel.org/4c48d016490d43b6892c622cbae858b48f176cff.1794304840.git.tanggeliang@xxxxxxxxxx [1]
>
>> Author: Geliang Tang <geliang@xxxxxxxxxx>
>
> [ ... ]
>
>> Signed-off-by: Geliang Tang <tanggeliang@xxxxxxxxxx>
>
> [Severity: Low]
> This isn't a bug, but the author address and the address in the author's
> sign-off are different. The author is geliang@xxxxxxxxxx, and the only
> sign-off from Geliang uses tanggeliang@xxxxxxxxxx. No sign-off uses the
> author address.
>
> scripts/checkpatch.pl reports this as a FROM_SIGN_OFF_MISMATCH warning
> ("From:/Signed-off-by: email address mismatch"). The names match exactly
> but the addresses do not, and checkpatch does not look at .mailmap.
>
> .mailmap already maps the two addresses to the same person:
>
> Geliang Tang <geliang@xxxxxxxxxx> <tanggeliang@xxxxxxxxxx>
>
> So this only affects the consistency of the tags. The DCO itself is not
> in question.
>
> Since this carries Cc: stable, could the author be set to the kylinos.cn
> address, or the sign-off use geliang@xxxxxxxxxx (changed or added), before
> the patch is applied?

False positive: the author is tanggeliang@xxxxxxxxxx, see the "From:"
line at the top of the email body. geliang@xxxxxxxxxx comes from
.mailmap.

This looks like a bug in Clashiko, Sashiko didn't report that.

Cheers,
Matt
--
Sponsored by the NGI0 Core fund.