Re: [PATCH] irqchip: Convert chained handlers to guard_chained_irq()
From: Changhuang Liang
Date: Tue Nov 17 2026 - 20:18:58 EST
hi
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Use the scope-based guard_chained_irq() helper in all chained handlers under
> drivers/irqchip/ so that chained_irq_exit() is always invoked when the handler
> returns. Handlers that duplicated the exit call on an error path or jumped to a
> common exit label simply return now and rely on the guard.
>
> No functional changes.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> With [1] now merged in irq/drivers, convert the chained IRQ handlers in
> drivers/irqchip/ to use guard_chained_irq(). This removes the explicit
> chained_irq_exit() calls and the gotos that only existed to reach them,
> reducing boilerplate.
>
> I use a script to do the job, and after that, do mannual checking.
>
> No functional changes.
>
> [1]
> https://lore.kernel.org/all/179417458323.2093942.14330197609841896598.
> tip-bot2@tip-bot2/#t
> ---
For drivers/irqchip/irq-starfive-jhb100-intc.c
Reviewed-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
Best Regards,
Changhuang