Re: [PATCH 3/4] accel/rocket: Fix the extra iommu_group_get call in rocket_job_handle_irq
From: Chaoyi Chen
Date: Tue Nov 17 2026 - 21:29:45 EST
Hi Daniel,
On 11/18/2026 5:53 AM, Daniel Drake wrote:
> On 14/08/2026 03:24, Chaoyi Chen wrote:
>> From: Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx>
>>
>> The rocket attaches the IOMMU group in rocket_job_run() and detaches it
>> in rocket_job_handle_irq(). Calling iommu_group_get() in
>> rocket_job_handle_irq() causes the reference count to increase
>> unexpectedly. And this causes rocket_core_fini() to fail to release the
>> IOMMU group, leading to a resource leak.
>
>
> While there is a leak here, I think sashiko correct in saying this change would introduce a crash because core->iommu_group can be set to NULL before this codepath is reached. That might be a simple fix.
>
>> Fixes: 658ebeac3351 ("accel/rocket: Add IOCTL for BO creation")
>
>
> Wrong commit mentioned here.
Thanks for you review. This is indeed a problem.
And it has been a long time since I sent this series. :)
During this time, I have seen a lot of similar work. For example, work
similar to patch1 is here[0]. And some of the issues mentioned by
Sashikoare also being fixed by in-flight patches like[1].
I'm not sure whether I should slow down the submission, since it seems
Tomeu is quite busy and hasn't gotten to some of the backlogged patches.
[0]: https://lore.kernel.org/all/20260915041152.1725014-1-vulab@xxxxxxxxxxx/
[1]: https://lore.kernel.org/all/18667b2afdcaae217fa1038f5348ab23ed756bdc.1794615323.git.gahing@xxxxxxxxxxxxx/
--
Best,
Chaoyi