Re: [PATCH 3/4] accel/rocket: Fix the extra iommu_group_get call in rocket_job_handle_irq
From: Tomeu Vizoso
Date: Wed Nov 18 2026 - 03:58:59 EST
Hi Chaoyi and Daniel,
On Wed, Nov 18, 2026 at 3:29 AM Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx> wrote:
>
> Hi Daniel,
>
> On 11/18/2026 5:53 AM, Daniel Drake wrote:
> > On 14/08/2026 03:24, Chaoyi Chen wrote:
> >> From: Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx>
> >>
> >> The rocket attaches the IOMMU group in rocket_job_run() and detaches it
> >> in rocket_job_handle_irq(). Calling iommu_group_get() in
> >> rocket_job_handle_irq() causes the reference count to increase
> >> unexpectedly. And this causes rocket_core_fini() to fail to release the
> >> IOMMU group, leading to a resource leak.
> >
> >
> > While there is a leak here, I think sashiko correct in saying this change would introduce a crash because core->iommu_group can be set to NULL before this codepath is reached. That might be a simple fix.
> >
> >> Fixes: 658ebeac3351 ("accel/rocket: Add IOCTL for BO creation")
> >
> >
> > Wrong commit mentioned here.
I fixed this one when applying.
> Thanks for you review. This is indeed a problem.
I'm sorry but I had already applied this patch to drm-misc-fixes and
pushed when I read this. I have looked at fixing just this crash, but
have decided against it because we anyway crash in drm_sched on core
unbind whenever a client is active (no need to have a job in flight),
due to the sched entities keeping a reference to the stale scheduler.
> And it has been a long time since I sent this series. :)
>
> During this time, I have seen a lot of similar work. For example, work
> similar to patch1 is here[0]. And some of the issues mentioned by
> Sashikoare also being fixed by in-flight patches like[1].
Core removal needs to be fixed as a whole: detach the open files'
entities from the scheduler that goes away, complete or cancel the job
in flight, and quiesce the job interrupt before the resources it uses
are released.
> I'm not sure whether I should slow down the submission, since it seems
> Tomeu is quite busy and hasn't gotten to some of the backlogged patches.
I'm sorry about the big backlog of patches. With Heiko and Daniel's
help I expect to get it cleared soon and be more responsive.
Regards,
Tomeu
> [0]: https://lore.kernel.org/all/20260915041152.1725014-1-vulab@xxxxxxxxxxx/
> [1]: https://lore.kernel.org/all/18667b2afdcaae217fa1038f5348ab23ed756bdc.1794615323.git.gahing@xxxxxxxxxxxxx/
>
> --
> Best,
> Chaoyi