Re: [PATCH 1/2] drm/panel-edp: Fix Innolux N125HCE-GN1 mode

From: Doug Anderson

Date: Tue Nov 17 2026 - 22:53:52 EST


Hi,

On Mon, Nov 16, 2026 at 4:11 AM Christian Gmeiner
<christian.gmeiner@xxxxxxxxx> wrote:
>
> From: Christian Gmeiner <cgmeiner@xxxxxxxxxx>
>
> The mode has a pixel clock of 162 MHz, which is 70 Hz. The EDID of the
> panel only has 60 Hz and 40 Hz. Output of edid-decode:
>
> DTD 1: 1920x1080 60.001038 Hz 16:9 66.721 kHz 138.780000 MHz
> Hfront 46 Hsync 30 Hback 84 Hpol P
> Vfront 2 Vsync 4 Vback 26 Vpol N
> DTD 2: 1920x1080 40.000692 Hz 16:9 44.481 kHz 92.520000 MHz
> Hfront 46 Hsync 30 Hback 84 Hpol P
> Vfront 2 Vsync 4 Vback 26 Vpol N
>
> On the MNT Reform 2 with i.MX8MQ the picture flickers at 70 Hz. Use the
> 60 Hz timing from the EDID.
>
> Fixes: a14c6b0eef77 ("panel-simple: add Innolux N125HCE-GN1")
> Signed-off-by: Christian Gmeiner <cgmeiner@xxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-edp.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)

Hmmm, this worries me a little bit. I know that on some boards people
purposely set a clock rate that didn't match the EDID because it was
the only rate achievable with the PLLs available. It kinda seems like
that's the case for at least one user of this board. In commit
eb893e34309c ("arm64: dts: mnt-reform2: add internal display
support"), for instance, I see:

> Clocking
> is derived from a system PLL, which provides quite good rate matching
> for the single supported display mode and keeps the video PLL free for
> usage with the external display, which isn't supported yet.

By picking a different rate here, you might break someone's setup.
...or is that your setup?

FWIW, it would be better to change how the panel is expressed in the
device tree rather than changing this mode. Can you change to using
the generic "edp-panel" under the AUX bus? Then everything just comes
from the EDID anyway.

-Doug