Re: [PATCH v3 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry
From: John Paul Adrian Glaubitz
Date: Wed Nov 18 2026 - 02:19:11 EST
Hi Ian,
On Tue, 2026-11-17 at 12:28 -0800, Ian Rogers wrote:
> On Sun, Nov 8, 2026 at 2:39 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with
> > kzalloc_obj() and initialized with ktype_percpu_entry. When
> > sq_dev_remove() calls kobject_put(kobj), the kobject is never freed
> > because ktype_percpu_entry lacks a .release callback.
> >
> > Provide a sq_kobj_release() callback that calls kfree(kobj).
> >
> > Fixes: d7c30c682a27 ("sh: Store Queue API rework.")
> > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
>
> Gentle ping on this patch (moving SuperH maintainers to To: in case
> this got buried in Cc:).
>
> Danilo offered to take the full 9-patch kobj_type::release __must_init
> series through the driver-core tree with subsystem ACKs, and this is
> one of the last two patches awaiting an Acked-by. Does this look okay
> to go via driver-core?
Sorry, this got buried somehow. The patch looks fine to me. Let me ack it.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913