Re: [PATCH v3 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry

From: John Paul Adrian Glaubitz

Date: Wed Nov 18 2026 - 02:20:23 EST


Hi Ian,

On Sun, 2026-11-08 at 14:39 -0800, Ian Rogers wrote:
> In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with
> kzalloc_obj() and initialized with ktype_percpu_entry. When
> sq_dev_remove() calls kobject_put(kobj), the kobject is never freed
> because ktype_percpu_entry lacks a .release callback.
>
> Provide a sq_kobj_release() callback that calls kfree(kobj).
>
> Fixes: d7c30c682a27 ("sh: Store Queue API rework.")
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c
> index 908a8e09113b..f33864958487 100644
> --- a/arch/sh/kernel/cpu/sh4/sq.c
> +++ b/arch/sh/kernel/cpu/sh4/sq.c
> @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = {
> .store = sq_sysfs_store,
> };
>
> +static void sq_kobj_release(struct kobject *kobj)
> +{
> + kfree(kobj);
> +}
> +
> static struct kobj_type ktype_percpu_entry = {
> + .release = sq_kobj_release,
> .sysfs_ops = &sq_sysfs_ops,
> .default_groups = sq_sysfs_groups,
> };

Looks good to me, thanks!

Acked-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913