Re: [PATCH v3 01/11] KVM: arm64: guest_memfd: Check mmap support when preparing memslot
From: Suzuki K Poulose
Date: Wed Nov 18 2026 - 07:05:06 EST
On 18/11/2026 11:14, Steven Price wrote:
On 18/11/2026 10:34, Suzuki K Poulose wrote:
Hi Steven
On 17/11/2026 14:05, Fuad Tabba wrote:
Hi Steven,
On Mon, 16 Nov 2026 16:43:47 +0000, Steven Price
<steven.price@xxxxxxx> wrote:
Check the guest_memfd backing file when deciding whether an arm64
memslot has mappable memory rather than checking whether the slot is
gmem only. A public helper function is added to be able to reuse the
static kvm_gmem_supports_mmap() function.
nit: could the message say why this is needed? It's a no-op until
patch 8 defines kvm_arch_has_private_mem(), which makes every
guest_memfd slot gmem-only.
I still don't understand why this is needed. For arm64 we have always
prevented guest_memfd without MMAP, in kvm_arch_prepare_memory_region().
Fuad is correct, this isn't really needed until patch 8. Patch 8 defines
kvm_arch_has_private_mem() - that means that gmem_in_place_conversion
becomes true (see include/linux/kvm_host.h). That in turn means that
every guest_memfd slot is KVM_MEMSLOT_GMEM_ONLY including slots backed
by a file without mmap support.
But we dont support slots without MMAP anyways even without this series.
So, does it really matter for arm64 ?
Suzuki
But regardless the check for kvm_memslot_is_gmem_only() isn't really
what the code is trying to do. The fact that the memslot is "gmem only"
isn't really relevant. The thing we care about is the mappability.
But I agree the commit message could do with improving. I'll expand that.
Thanks,
Steve