Re: [PATCH v3 01/11] KVM: arm64: guest_memfd: Check mmap support when preparing memslot

From: Steven Price

Date: Wed Nov 18 2026 - 10:20:14 EST


On 18/11/2026 12:04, Suzuki K Poulose wrote:
> On 18/11/2026 11:14, Steven Price wrote:
>> On 18/11/2026 10:34, Suzuki K Poulose wrote:
>>> Hi Steven
>>>
>>> On 17/11/2026 14:05, Fuad Tabba wrote:
>>>> Hi Steven,
>>>>
>>>> On Mon, 16 Nov 2026 16:43:47 +0000, Steven Price
>>>> <steven.price@xxxxxxx> wrote:
>>>>> Check the guest_memfd backing file when deciding whether an arm64
>>>>> memslot has mappable memory rather than checking whether the slot is
>>>>> gmem only. A public helper function is added to be able to reuse the
>>>>> static kvm_gmem_supports_mmap() function.
>>>>
>>>> nit: could the message say why this is needed? It's a no-op until
>>>> patch 8 defines kvm_arch_has_private_mem(), which makes every
>>>> guest_memfd slot gmem-only.
>>>
>>> I still don't understand why this is needed. For arm64 we have always
>>> prevented guest_memfd without MMAP, in kvm_arch_prepare_memory_region().
>>
>> Fuad is correct, this isn't really needed until patch 8. Patch 8 defines
>> kvm_arch_has_private_mem() - that means that gmem_in_place_conversion
>> becomes true (see include/linux/kvm_host.h). That in turn means that
>
>> every guest_memfd slot is KVM_MEMSLOT_GMEM_ONLY including slots backed
>> by a file without mmap support.
>
> But we dont support slots without MMAP anyways even without this series.
>  So, does it really matter for arm64 ?

So ChatGPT produced the attached test. It creates a non-mappable gmem
and tries to add it to a normal (non-realm/non-pkvm) VM. With v7.4-rc1
it is rejected. However without this patch it succeeds.

The issue is that gmem_in_place_conversion changes the behaviour for
normal VMs.

Thanks,
Steve

// SPDX-License-Identifier: GPL-2.0-only
/*
* Reproduce the non-Realm guest_memfd memslot regression.
* Build from the kernel root with:
* cc -Wall -Wextra -O2 -Itools/include -Itools/include/uapi \
* tools/testing/selftests/kvm/arm64/guest_memfd_nommap_repro.c -o /tmp/gmem-repro
*/
#include <errno.h>
#include <fcntl.h>
#include <linux/kvm.h>
#include <stdint.h>
#include <stdio.h>
#include <sys/ioctl.h>
#include <sys/mman.h>
#include <unistd.h>

int main(void)
{
long size = sysconf(_SC_PAGESIZE);
struct kvm_create_guest_memfd gmem = { .size = size };
struct kvm_userspace_memory_region2 region = {
.flags = KVM_MEM_GUEST_MEMFD,
.memory_size = size,
};
int kvm, vm, fd, ret, error;
void *hva;

if (size <= 0)
return 1;
kvm = open("/dev/kvm", O_RDWR | O_CLOEXEC);
if (kvm < 0) {
perror("open /dev/kvm");
return 1;
}
vm = ioctl(kvm, KVM_CREATE_VM, 0);
if (vm < 0) {
perror("KVM_CREATE_VM");
return 1;
}
fd = ioctl(vm, KVM_CREATE_GUEST_MEMFD, &gmem);
if (fd < 0) {
perror("KVM_CREATE_GUEST_MEMFD");
return 1;
}
hva = mmap(NULL, size, PROT_READ | PROT_WRITE,
MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
if (hva == MAP_FAILED) {
perror("mmap");
return 1;
}
region.userspace_addr = (uintptr_t)hva;
region.guest_memfd = fd;
ret = ioctl(vm, KVM_SET_USER_MEMORY_REGION2, &region);
error = errno;
if (ret == -1 && error == EINVAL) {
puts("PASS: non-mappable guest_memfd memslot rejected");
return 0;
}
fprintf(stderr, "FAIL: KVM_SET_USER_MEMORY_REGION2 returned %d (errno %d)\n",
ret, ret < 0 ? error : 0);
return 1;
}