Re: [PATCH rtw-next v6 3/5] wifi: rtw89: restore channel when leaving idle on non-chanctx devices
From: Enver Ikromov
Date: Wed Nov 18 2026 - 13:04:39 EST
On Wed, Nov 18, 2026 at 06:30:01 +0000, Zong-Zhe Yang wrote:
> Additionally,
> (changed & (IEEE80211_CONF_CHANGE_IDLE |
> IEEE80211_CONF_CHANGE_MONITOR))
> seems to be true for any first iface (even if not a monitor) by
> ieee80211_hw_conf_init(). So, perhaps the condition should be
>
> If (!rtwdev->support_chanctx &&
> changed & IEEE80211_CONF_CHANGE_IDLE &&
> changed & IEEE80211_CONF_CHANGE_ MONITOR &&
> !(hw->conf.flags & IEEE80211_CONF_IDLE) &&
> hw->conf.flags & IEEE80211_CONF_MONITOR)
Good catch on ieee80211_hw_conf_init(). I will drop the local variable
and add the IEEE80211_CONF_MONITOR check in v7.
Thanks,
Enver