Re: [RFC PATCH 3/4] drm/tilcdc: Implement state readout support
From: Màxim Pedraza Padilla
Date: Wed Nov 18 2026 - 16:21:26 EST
On Mon, Nov 16, 2026 at 06:12:50PM +0100, Maxime Ripard wrote:
> > - The channel order isn't stored, so RGB is reported for the adopted
> > framebuffer. It doesn't change what's on screen.
>
> You mean RGB vs BGR? It's not available anywhere in a register?
Right, there's no swap bit in the LCDC. The order comes from the board
wiring, which the DT describes with blue-and-red-wiring, and the driver
already uses it to pick the format list. I'll use that in the readout
instead of always reporting RGB.
> > - tilcdc_crtc_mode_fixup() is undone to get the requested mode, but a
> > positive sync can't be told from a mode that doesn't specify it.
>
> That's suprising as well, the polairity of signals is typically stored
> somewhere in a register.
It is, in RASTER_TIMING_2 (INVERT_HSYNC and INVERT_VSYNC), so the actual
polarity is read back fine. What's lost is the difference between a mode
that asks for DRM_MODE_FLAG_PHSYNC and one with no polarity flag at all:
both end up with the same register value, and the readout can only pick
one of them. I'll reword the commit message.
> You need to give some leeway there. It's unlikely you'll ever going to
> be an exact match for the mode being used due to clock rounding.
> [...]
> We handle that in tidss by looking for the closest rate match and see if
> it falls into the specified tolerance
> (dispc_find_closest_refresh_rate_from_clk). I always thought of it as
> something that could be turned into a helper, and it's what you should
> be using here.
Makes sense, I'll use the same approach in tilcdc, and see if it can be
turned into a common helper along the way.
> That part is
> https://lore.kernel.org/all/20261116-drm-no-more-config-reset-v2-43-0bb471f4d1e0@xxxxxxxxxx/
> with hw_reset that sashiko pointed out
Ok, I'll drop it from my patch and base on top of that one.
Thanks,
Màxim