Re: [PATCH ath-next] wifi: ath10k: free msdu_id and skb reference when HL TX fails

From: Changyul Lee

Date: Wed Nov 18 2026 - 16:56:45 EST


Hi Loic,

Thanks for the review.

On Wed, Nov 18, 2026 at 9:53 AM Loic Poulain wrote:
> The above message looks too verbose and confusing for a somewhat
> simple issue. Maybe this should be split properly in two fixes.

I originally wanted to fix the msdu_id leak. ath10k_htt_tx_hl()
allocates an msdu_id in htt->pending_tx, but leaves the entry there
if ath10k_htc_send_hl() fails.

I also noticed that the same error path doesn't drop the extra skb
reference taken by skb_get(), so I included both fixes in v1. I think
I could have explained this more clearly when covering both fixes
together. Sorry for the confusion.

> If this is a fix you should not target 'ath-next'.
> Two fixes tag looks weird, what are you fixin exactly?

I Cc'd Wentao Liang because he had already posted a patch for the skb
reference leak [1], but I left that explanation out of v1. Would it be
okay if I sent a v2 that only fixes the msdu_id leak?

[1] https://lore.kernel.org/all/20260917120112.2150211-1-vulab@xxxxxxxxxxx/

Thanks,
Changyul