Re: [PATCH ath-next] wifi: ath10k: free msdu_id and skb reference when HL TX fails

From: Jeff Johnson

Date: Wed Nov 18 2026 - 18:09:12 EST


On 11/18/2026 1:56 PM, Changyul Lee wrote:
> Hi Loic,
>
> Thanks for the review.
>
> On Wed, Nov 18, 2026 at 9:53 AM Loic Poulain wrote:
>> The above message looks too verbose and confusing for a somewhat
>> simple issue. Maybe this should be split properly in two fixes.
>
> I originally wanted to fix the msdu_id leak. ath10k_htt_tx_hl()
> allocates an msdu_id in htt->pending_tx, but leaves the entry there
> if ath10k_htc_send_hl() fails.
>
> I also noticed that the same error path doesn't drop the extra skb
> reference taken by skb_get(), so I included both fixes in v1. I think
> I could have explained this more clearly when covering both fixes
> together. Sorry for the confusion.
>
>> If this is a fix you should not target 'ath-next'.
>> Two fixes tag looks weird, what are you fixin exactly?
>
> I Cc'd Wentao Liang because he had already posted a patch for the skb
> reference leak [1], but I left that explanation out of v1. Would it be
> okay if I sent a v2 that only fixes the msdu_id leak?
>
> [1] https://lore.kernel.org/all/20260917120112.2150211-1-vulab@xxxxxxxxxxx/
FWIW I've rejected all patches from vulab@xxxxxxxxxxx since multiple folks
were using the same e-mail address which is contrary to the DCO. So I'm
waiting to see if there is a repost with an individualized e-mail address.

But I also don't want multiple fixes in a single patch because then it
complicates backporting to stable kernels (unless both of the patches being
fixed were originally part of the same kernel or both predate v5.10).

/jeff