Re: [PATCH net-next v2 2/3] RDMA/ionic: Use the ionic command timeout for the admin queue

From: Rao, Nikhil

Date: Wed Nov 18 2026 - 18:40:28 EST


On 11/10/2026 4:14 AM, netdev-bot+sashiko@xxxxxxxxxx wrote:

[Severity: Low]
This fixes a user-visible problem, but the patch has no Fixes: tag.
The 2 second IONIC_ADMIN_TIMEOUT removed above was added by f3bdbd42702c
("RDMA/ionic: Create device queues to support admin operations"), which
is in released kernels.

Should this carry a Fixes: tag for that commit?
Agreed. The 2 to 5 second change is sent separately to rdma for-rc:
https://patch.msgid.link/20261118-b4-ionic-rdma-admin-timeout-v1-1-39536999a3e4@xxxxxxx

[Severity: High]
Only the watchdog in ionic_admin_dwork() moves to ionic_cmd_timeout()
here. Can the RDMA LIF still be reset after 2 seconds through the AH
busy-wait path?


Should the busy-wait also be bounded by ionic_cmd_timeout(), or should
its expiry not trigger the LIF reset?

The busy-wait keeps its 2 second bound: it serves non-sleepable
callers such as cm_alloc_msg(), which runs with a spinlock held, so it
cannot spin for the command timeout, which can now be up to 255
seconds. Its expiry still resets the RDMA LIF, as the admin queue
watchdog's does, so non-sleepable AH commands keep the 2 second limit.
Admin commands that sleep until completion, including every verb from
user space, follow the configured timeout.

Nikhil