Re: [patch] 2.3.39pre2: typo in atm/nicstar.c

• Next message: Alan Cox: "Re: stuff about proc (was: [something. blame elm])"
• Previous message: Andrea Arcangeli: "Re: an experiment in pipe bandwidth improvement"
• In reply to: Tim Waugh: "[patch] 2.3.39pre2: typo in atm/nicstar.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Tim Waugh wrote:
> --- linux-2.3.39pre2/drivers/atm/nicstar.c~ Sun Jan 9 18:16:07 2000
> +++ linux-2.3.39pre2/drivers/atm/nicstar.c Sun Jan 9 18:16:19 2000
> @@ -502,7 +502,7 @@ static int ns_init_card(int i, struct pc
> PRINTK("nicstar%d: setting PCI latency timer to %d.\n", i, NS_PCI_LATENCY);
> for (j = 1; j < 4; j++)
> {
> - if (pci_write_config_byte(pcidev, PCI_LATENCY_TIMER, NS_PCI_LATENCY) != 0);
> + if (pci_write_config_byte(pcidev, PCI_LATENCY_TIMER, NS_PCI_LATENCY) != 0)
> break;
> }

Yeah, I actually spotted that one too a few months ago, but it looks like
I forgot to send out an email about it (oops). I'd recommend removing
the loop entirely, because:
  * It doesn't seem to be common to re-try setting the latency timer in
    other drivers
  * Since the "break" was running unconditionally (due to the bug) the
    driver was never re-trying anyway, and we seem to have survived.

-Mitch

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Alan Cox: "Re: stuff about proc (was: [something. blame elm])"
• Previous message: Andrea Arcangeli: "Re: an experiment in pipe bandwidth improvement"
• In reply to: Tim Waugh: "[patch] 2.3.39pre2: typo in atm/nicstar.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:17 EST