Re: [PATCH (2.4)] atomic use count for proc_dir_entry

From: Jacob Luna Lundberg (jacob@velius.chaos2.org)
Date: Fri Nov 17 2000 - 00:21:13 EST


I'm not (yet) a kernel guru, so just point and laugh if I'm wrong, but...

On Thu, 16 Nov 2000, Dan Aloni wrote:
> - if (!--de->count) {
> + if (atomic_dec_and_test(&de->count)) {

Doesn't this reverse the sense of the test?

-Jacob

-- 

"My my, the cruelest lies are often told without a word. My my, the kindest truths are often spoke, but never heard."

-Ben Folds Five, "The Last Polka"

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:12 EST