Re: [PATCH (2.4)] atomic use count for proc_dir_entry

• Next message: Jarosław Bekas: "2.4.0-test11-pre6 dev.c compile error"
• Previous message: Alexander Viro: "[PATCH] fs_may_remount_ro()/fput() race fix and ->f_dentry cleanups"
• In reply to: Jacob Luna Lundberg: "Re: [PATCH (2.4)] atomic use count for proc_dir_entry"
• Next in thread: Jacob Luna Lundberg: "Re: [PATCH (2.4)] atomic use count for proc_dir_entry"
• Reply: Jacob Luna Lundberg: "Re: [PATCH (2.4)] atomic use count for proc_dir_entry"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, 16 Nov 2000, Jacob Luna Lundberg wrote:

>
> I'm not (yet) a kernel guru, so just point and laugh if I'm wrong, but...
>
> On Thu, 16 Nov 2000, Dan Aloni wrote:
> > - if (!--de->count) {
> > + if (atomic_dec_and_test(&de->count)) {
>
> Doesn't this reverse the sense of the test?

If you are right, I guess put_files_struct() of kernel/exit.c would
have cleaned files_struct everytime someones called it.
Everywhere in the kernel, objects are freed when
atomic_dec_and_test() returns true.

-- 
Dan Aloni 
dax@karrde.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Jarosław Bekas: "2.4.0-test11-pre6 dev.c compile error"
• Previous message: Alexander Viro: "[PATCH] fs_may_remount_ro()/fput() race fix and ->f_dentry cleanups"
• In reply to: Jacob Luna Lundberg: "Re: [PATCH (2.4)] atomic use count for proc_dir_entry"
• Next in thread: Jacob Luna Lundberg: "Re: [PATCH (2.4)] atomic use count for proc_dir_entry"
• Reply: Jacob Luna Lundberg: "Re: [PATCH (2.4)] atomic use count for proc_dir_entry"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:12 EST