[PATCH] maestro3 2.4.4-pre5 fixes

• Next message: Disconnect: "Re: Athlon problem report summary"
• Previous message: Eric S. Raymond: "Re: [parisc-linux] Re: OK, let's try cleaning up another nit. Is anyone paying attention?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

The maestro3 driver has a error cleanup bug that would leave its reboot
notifier registerd after exiting init_module with an error. Bayad.
It also had a minor bug where it didn't explicitly set the codec->id
before probing..

this patch vs 2.4.4-pre5 (I hope, its really vs jeff's cvs :)) fixes both.

Linus, please apply.

-- 
 zach
Index: maestro3.c
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/drivers/sound/maestro3.c,v
retrieving revision 1.1.1.24.6.1
diff -u -r1.1.1.24.6.1 maestro3.c
--- maestro3.c	2001/04/20 01:40:38	1.1.1.24.6.1
+++ maestro3.c	2001/04/21 14:36:21
@@ -2307,6 +2307,8 @@
     codec->private_data = card;
     codec->codec_read = m3_ac97_read;
     codec->codec_write = m3_ac97_write;
+    /* someday we should support secondary codecs.. */
+    codec->id = 0;
 
     if (ac97_probe_codec(codec) == 0) {
         printk(KERN_ERR PFX "codec probe failed\n");
@@ -2933,6 +2935,7 @@
 
     if (!pci_register_driver(&m3_pci_driver)) {
         pci_unregister_driver(&m3_pci_driver);
+        unregister_reboot_notifier(&m3_reboot_nb);
         return -ENODEV;
     }
     return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Disconnect: "Re: Athlon problem report summary"
• Previous message: Eric S. Raymond: "Re: [parisc-linux] Re: OK, let's try cleaning up another nit. Is anyone paying attention?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:39 EST