Re: [PATCH] zero^H^H^H^Hsingle copy pipe

• Next message: Matthew Kirkwood: "Re: [PATCH] arp_filter patch for 2.4.4 kernel."
• Previous message: Ben LaHaise: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• In reply to: Ben LaHaise: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Next in thread: Ben LaHaise: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Reply: Ben LaHaise: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Reply: Alan Cox: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Reply: David S. Miller: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: "Ben LaHaise" <bcrl@redhat.com>
>
> Any particular reason for not using davem's single copy kiobuf based
> code?
>
The main problem is that map_user_kiobuf() locks pages into memory.
It's a bad idea for pipes. Either we must severely limit the maximum
amount of data in the direct-copy buffers, or we must add a swap file
based backing store. If I understand the BSD direct-pipe code correctly
it has a swap file based backing store. I think that's insane. And
limiting the direct copy buffers to a few kB defeats the purpose of
direct copy.
Instead pipe_write just queues (tsk,addr,len), and then pipe_read() uses
a modified access_process_vm() function to copy directly. Currently I've
copied the code from kernel/ptrace.c, but I plan to merge
copy_user_to_user() back into access_process_vm().

And the current pipe_{read,write} are a total mess with nested loops and
gotos. It's possible to create wakeup storms. I rewrote them as well ;-)

But the new code still contains one deadlock :-(

--
    Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Matthew Kirkwood: "Re: [PATCH] arp_filter patch for 2.4.4 kernel."
• Previous message: Ben LaHaise: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• In reply to: Ben LaHaise: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Next in thread: Ben LaHaise: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Reply: Ben LaHaise: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Reply: Alan Cox: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Reply: David S. Miller: "Re: [PATCH] zero^H^H^H^Hsingle copy pipe"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon May 07 2001 - 21:00:25 EST