Re: Fwd: Hard Lockup on 2.4.16 with Via ieee1394 (sbp2 mode)

From: Matthew Dharm (mdharm-kernel@one-eyed-alien.net)
Date: Sat Dec 29 2001 - 00:11:13 EST

It should be using scsi_done()... it actually seems to use whatever was
given as a done function at the queuecommand point, which is, I think,
scsi_done().

Matt

On Fri, Dec 28, 2001 at 08:59:17PM -0800, Andrew Morton wrote:
> Matthew Dharm wrote:
> >
> > Hrm...
> >
> > Does this apply to usb-storage also? Under what conditions do you need to
> > hold the io_request_lock when calling the done function?
> >
>
> That's scsi_old_done(). I don't think scsi_done() cares whether
> io_request_lock is held or not.
>
> And io_request_lock *must* be held by the caller of scsi_old_done() - it
> assumes this. I think we'd have heard by now if usb was getting this
> wrong. Looks like it's using scsi_done(), yes?
>
> - 

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

Sir, for the hundreth time, we do NOT carry 600-round boxes of belt-fed 
suction darts!
					-- Salesperson to Greg
User Friendly, 12/30/1997
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Dec 31 2001 - 21:00:19 EST