Re: [PATCH] IDE 58

From: Paul Mackerras (paulus@samba.org)
Date: Wed May 08 2002 - 01:42:05 EST


Martin Dalecki writes:

> - Virtualize the udma_enable method as well to help ARM and PPC people. Please
> please if you would like to have some other methods virtualized in a similar
> way - just tell me or even better do it yourself at the end of ide-dma.c.
> I *don't mind* patches.
>
> - Fix the pmac code to adhere to the new API. It's supposed to work again.
> However this is blind coding... I give myself 80% chances for it to work ;-).

OK, now I am truly impressed. Not only does it compile cleanly, it
works first go!

I am using the tiny patch below, it sets the unmask flag so interrupts
will be unmasked by default (which is safe on powermacs).

Thanks,
Paul.

diff -urN linux-2.5/drivers/ide/ide-pmac.c pmac-2.5/drivers/ide/ide-pmac.c
--- linux-2.5/drivers/ide/ide-pmac.c Wed May 8 16:40:17 2002
+++ pmac-2.5/drivers/ide/ide-pmac.c Wed May 8 08:26:48 2002
@@ -343,6 +343,7 @@
                         ide_hwifs[ix].autodma = 1;
 #endif
         }
+ ide_hwifs[ix].unmask = 1;
 }
 
 #if 0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 14 2002 - 12:00:08 EST