2.4.19-pre10-ac2, compile warnings/failures

From: David Ford (david+cert@blue-labs.org)
Date: Mon Jun 10 2002 - 16:23:11 EST


cpqphp.h: In function `cpq_get_latch_status':
cpqphp.h:698: warning: concatenation of string literals with
__FUNCTION__ is deprecated
cpqphp.h: In function `wait_for_ctrl_irq':
cpqphp.h:736: warning: concatenation of string literals with
__FUNCTION__ is deprecated
cpqphp.h:746: warning: concatenation of string literals with
__FUNCTION__ is deprecated

cpqphp_nvram.c:163: warning: concatenation of string literals with
__FUNCTION__ is deprecated

cpqphp_nvram.c:179:17: missing terminating " character
cpqphp_nvram.c: In function `access_EV':
cpqphp_nvram.c:180: parse error before "xorl"
cpqphp_nvram.c:184:28: missing terminating " character

People, please don't do things like:

   spin_lock_irqsave(&int15_lock, flags);
   __asm__ (
      "xorl %%ebx,%%ebx
      xorl %%edx,%%edx
      pushf
      push %%cs
      cli
      call *%6"

Patches keep going in to fix this.

Please do something like:

   spin_lock_irqsave(&int15_lock, flags);
   __asm__ (
      "xorl %%ebx,%%ebx \n"
      "xorl %%edx,%%edx \n"
      "pushf \n"
      "push %%cs \n"
      "cli \n"
      "call *%6 \n"

i2o_core.c:3393:75: missing terminating " character
         printk(KERN_WARNING "i2o: Could not quiesce %s." "
            Verify setup on next system power up.\n", c->name);

Please write it like:

         printk(KERN_WARNING "i2o: Could not quiesce %s."
            "Verify setup on next system power up.\n", c->name);

-d

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:19 EST