Re: [2.5 patch] tiglusb.c must include version.h

• Next message: Matti Aarnio: "Re: The spam problem."
• Previous message: Daniel Phillips: "Re: large page patch (fwd) (fwd)"
• In reply to: Brad Hards: "Re: [2.5 patch] tiglusb.c must include version.h"
• Next in thread: Greg KH: "Re: [2.5 patch] tiglusb.c must include version.h"
• Reply: Greg KH: "Re: [2.5 patch] tiglusb.c must include version.h"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Brad Hards <bhards@bigpond.net.au> wrote:

Hi,

>> line 44 is:
>> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
>>
>>
>> The fix is simple:
> <snip>
>> +#include <linux/version.h>
>
> Wouldn't it be cleaner to just remove this case? It is in 2.5, after all.

We use this case so we don't have to maintain 2 /slightly/ different
versions of the source, as we're distributing this module outside of
the kernel tree for use with kernel 2.4.x.

Moreover I asked Greg to push this module into the 2.4 tree if
possible, so as long as there aren't major changes in the 2.5 code
I'd really like to keep the same source for 2.4 and 2.5.

But if this should become a hassle for anybody, I'll remove this case
ASAP.

JB.

-- 
Julien BLACHE                                   <http://www.jblache.org> 
<jb@jblache.org> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Matti Aarnio: "Re: The spam problem."
• Previous message: Daniel Phillips: "Re: large page patch (fwd) (fwd)"
• In reply to: Brad Hards: "Re: [2.5 patch] tiglusb.c must include version.h"
• Next in thread: Greg KH: "Re: [2.5 patch] tiglusb.c must include version.h"
• Reply: Greg KH: "Re: [2.5 patch] tiglusb.c must include version.h"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:27 EST