Re: patch for 2.5.42. 2/2

From: Hu Gang (hugang@soulinfo.com)
Date: Sat Oct 12 2002 - 22:33:29 EST

On Sun, 13 Oct 2002 01:34:22 -0200 (BRST)
Rik van Riel <riel@conectiva.com.br> wrote:

|On Sun, 13 Oct 2002, Hu Gang wrote:
|
|> --- linux-2.5.42/drivers/net/3c59x.c Sat Oct 12 21:25:00 2002
|> +++ linux-2.5.42-suspend/drivers/net/3c59x.c Sat Oct 12 21:20:48 2002
|
|> +#ifdef CONFIG_PM
|> + int in_suspend;
|> +#endif
|
|This looks like a serious design mistake. Surely it would be
|better to just have the network layer stop operations when the
|system is going into suspend, instead of having to modify 100
|individual network drivers ?

Yes, The other drivers have this problem , such as sound.

I'm can not confirm that idea is the best way. But I can not found any other way can do it. If you have good idea, Tell me know.

thanks. 

-- 
		- Hu Gang
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:45 EST