On Wed, Jan 15, 2003 at 10:44:52AM -0500, Stephen D. Smalley wrote:
>
> "Andi Kleen" <ak@muc.de> writes:
> > Adding release_private_file requires fixing all code that uses
> > init_private_file (including possible third party code). Otherwise
> > you have some subtle leak. It would better to rename init_private_file to
> > some other name and add appropiate comments so that this can be catched
> > easily at compile time.
>
> Thanks for the suggestion. I've split out this logical change into a
> separate patch and reworked it in accordance with your suggestion. See
> below. Let me know if this does not address your concern.
Once you're at it please aqdd an argument to set file.f_flags so the
caller can set O_LARGEFILE properly. The (unmerged) XFS dmapi code wants
that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:54 EST