Re: [PATCH 2.6] fix pci_update_resource() / IORESOURCE_UNSET on PPC

[Greg KH]

On Wed, Dec 24, 2003 at 12:10:55PM +0100, Harald Welte wrote:
> Hi!
> 
> [disclaimer:  This was posted on the linuxppc list before, BenH asked me 
>  to re-post it to lkml]
> 
> The prism54 (http://prism54.org) driver for my cardbus adapter works
> with 2.4.x, but not 2.6.x on a Titanium G4 Powerbook IV.
> 
> On 2.6.x the error message was
> PCI:0001:02:00.0 Resource 0 [00000000-00001fff] is unassigned
> 
> After investigating differences in the PCI code of 2.4.x and 2.6.x, i
> noticed that 2.4.x/arc/ppc/kernel/pci.c:pcibios_update_resource()
> contained a couple of lines that unset the IORESOURCE_UNSET bitflag.
> 
> In 2.6.x, this is handled by the generic PCI core in
> drivers/pci/setup-res.c:pci_update_resource() code.  However, the code
> is missing the 'res->flags &= ~IORESOURCE_UNSET' part.
> 
> The below fix re-adds that section from 2.4.x. 
> 
> I'm not sure wether this belongs into the arch-independent PCI api.
> Anyway, on PPC it seems to be needed for certain cardbus devices.

Is there any way you can add this to the ppc arch specific code, as
that's the only platform that seems to want this, right?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/