Re: [PATCH][2.6] IBM PowerPC Virtual Ethernet Driver

[Benjamin Herrenschmidt]

On Wed, 2004-02-18 at 09:48, Santiago Leon wrote:
> Here's a patch that adds the inter-partition Virtual Ethernet driver for 
> newer IBM iSeries and pSeries systems:
> 
> The patch applies against 2.6.3-rc3...
> 
> Jeff, can you formally add this driver to 2.6?... The differences 
> between this driver and the 2.4 driver that you accepted are fairly 
> trivial (i.e. workqueues instead of tasklets)... The architectural 
> additions that I was waiting for have been applied to the mainline tree...
> 
> Comments and suggestions are always welcome...

Let me put my though police hat for a short while...

BITFIELDS ARE EVIL !!!

Especially when mapping things like HW registers... I know the p/iSeries
code is full of them, I'd strongly recommend getting rid of them.

The compiler is perfectly free, afaik, to re-order them, you have no
guarantee of your actual layout, and it's not portable (I know nothing
but PPC uses those drivers _right_ now, but still...)

So please, don't add more ;)
 
Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/