Re: [PATCH][2.6] IBM PowerPC Virtual Ethernet Driver

From: Dave Jones
Date: Tue Feb 17 2004 - 23:08:30 EST


On Wed, Feb 18, 2004 at 11:45:20AM +1100, Benjamin Herrenschmidt wrote:

> BITFIELDS ARE EVIL !!!
>
> Especially when mapping things like HW registers... I know the p/iSeries
> code is full of them, I'd strongly recommend getting rid of them.
>
> The compiler is perfectly free, afaik, to re-order them

That can't be right surely ? That would make them utterly useless afaics.
I've not seen this happen in practice either with the 2 x86 cpufreq drivers
I wrote that both use bitfields extensively.

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/