Re: [PATCH] Enable Intel AGP on x86-64

From: Andi Kleen
Date: Wed Feb 18 2004 - 15:38:03 EST


On Wed, 18 Feb 2004 20:23:25 +0000
Dave Jones <davej@xxxxxxxxxx> wrote:

> On Wed, Feb 18, 2004 at 07:44:38PM +0000, Linux Kernel wrote:
> > ChangeSet 1.1564, 2004/02/18 11:44:38-08:00, ak@xxxxxxx
> >
> > [PATCH] Enable Intel AGP on x86-64
> >
> > Enable the Intel AGP driver for x86-64 too.
>
> Please don't do this. At least copy intel-agp.c to
> something new and throw out all the dozens of chipsets
> that will never appear on ia32e.
>
> Splitting agpgart up to seperate drivers allowed us
> to stop adding cruft upon cruft with each generation
> of chipsets. I don't want to have to spend half of
> 2.7 decrufting agpgart again.

Huh? Did you actually read the patch? It doesn't change the AGP
driver at all, just enables it in Kconfig because Intel chipsets
can be now used on the x86-64 kernel too.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/